Receive test management settings from CIVis settings request #8331

daniel-mohedano · 2025-02-04T10:01:26Z

What Does This Do

Updates CIVis settings request to receive the test_management settings field
Updates CIVis telemetry accordingly
Sets test.test_management.enabled tag on test_session_end events when feature is enabled

Motivation

First step in the implementation of Flaky Test Management.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: SDTEST-1530

pr-commenter · 2025-02-04T10:37:25Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/test-management-setting
git_commit_date	1738664773	1738684695
git_commit_sha	`b9533be`	`e78edfa`
release_version	1.47.0-SNAPSHOT~b9533be551	1.47.0-SNAPSHOT~e78edfa92c

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738687444	1738687444
ci_job_id	793507858	793507858
ci_pipeline_id	54858573	54858573
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-fdzndate-project-304-concurrent-0-0opji0d6 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-fdzndate-project-304-concurrent-0-0opji0d6 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.044 s) : 0, 1043804
Total [baseline] (8.62 s) : 0, 8620404
Agent [candidate] (1.06 s) : 0, 1059961
Total [candidate] (8.654 s) : 0, 8653988
section iast
Agent [baseline] (1.189 s) : 0, 1188997
Total [baseline] (9.25 s) : 0, 9249691
Agent [candidate] (1.182 s) : 0, 1182367
Total [candidate] (9.246 s) : 0, 9246313
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171907
Total [baseline] (9.187 s) : 0, 9187143
Agent [candidate] (1.173 s) : 0, 1172831
Total [candidate] (9.196 s) : 0, 9195914
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168529
Total [baseline] (9.218 s) : 0, 9217608
Agent [candidate] (1.169 s) : 0, 1169015
Total [candidate] (9.197 s) : 0, 9197188

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	iast	1.189 s	145.193 ms (13.9%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.172 s	128.103 ms (12.3%)
Agent	iast_TELEMETRY_OFF	1.169 s	124.725 ms (11.9%)
Total	tracing	8.62 s	-
Total	iast	9.25 s	629.287 ms (7.3%)
Total	iast_HARDCODED_SECRET_DISABLED	9.187 s	566.739 ms (6.6%)
Total	iast_TELEMETRY_OFF	9.218 s	597.205 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.06 s	-
Agent	iast	1.182 s	122.405 ms (11.5%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.173 s	112.869 ms (10.6%)
Agent	iast_TELEMETRY_OFF	1.169 s	109.054 ms (10.3%)
Total	tracing	8.654 s	-
Total	iast	9.246 s	592.325 ms (6.8%)
Total	iast_HARDCODED_SECRET_DISABLED	9.196 s	541.926 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.197 s	543.2 ms (6.3%)

gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (717.275 ms) : 0, 717275
BytebuddyAgent [candidate] (726.057 ms) : 0, 726057
GlobalTracer [baseline] (243.738 ms) : 0, 243738
GlobalTracer [candidate] (247.087 ms) : 0, 247087
AppSec [baseline] (55.23 ms) : 0, 55230
AppSec [candidate] (55.943 ms) : 0, 55943
Remote Config [baseline] (720.954 µs) : 0, 721
Remote Config [candidate] (734.444 µs) : 0, 734
Telemetry [baseline] (11.657 ms) : 0, 11657
Telemetry [candidate] (14.754 ms) : 0, 14754
section iast
BytebuddyAgent [baseline] (847.301 ms) : 0, 847301
BytebuddyAgent [candidate] (842.073 ms) : 0, 842073
GlobalTracer [baseline] (236.64 ms) : 0, 236640
GlobalTracer [candidate] (235.7 ms) : 0, 235700
IAST [baseline] (24.475 ms) : 0, 24475
IAST [candidate] (24.872 ms) : 0, 24872
AppSec [baseline] (55.803 ms) : 0, 55803
AppSec [candidate] (54.737 ms) : 0, 54737
Remote Config [baseline] (627.848 µs) : 0, 628
Remote Config [candidate] (626.771 µs) : 0, 627
Telemetry [baseline] (8.688 ms) : 0, 8688
Telemetry [candidate] (8.737 ms) : 0, 8737
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.116 ms) : 0, 834116
BytebuddyAgent [candidate] (834.265 ms) : 0, 834265
GlobalTracer [baseline] (233.659 ms) : 0, 233659
GlobalTracer [candidate] (234.209 ms) : 0, 234209
IAST [baseline] (25.638 ms) : 0, 25638
IAST [candidate] (27.41 ms) : 0, 27410
AppSec [baseline] (53.895 ms) : 0, 53895
AppSec [candidate] (52.34 ms) : 0, 52340
Remote Config [baseline] (622.288 µs) : 0, 622
Remote Config [candidate] (615.418 µs) : 0, 615
Telemetry [baseline] (8.745 ms) : 0, 8745
Telemetry [candidate] (8.721 ms) : 0, 8721
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.556 ms) : 0, 831556
BytebuddyAgent [candidate] (831.014 ms) : 0, 831014
GlobalTracer [baseline] (233.81 ms) : 0, 233810
GlobalTracer [candidate] (234.5 ms) : 0, 234500
IAST [baseline] (25.881 ms) : 0, 25881
IAST [candidate] (27.064 ms) : 0, 27064
AppSec [baseline] (52.829 ms) : 0, 52829
AppSec [candidate] (52.153 ms) : 0, 52153
Remote Config [baseline] (613.193 µs) : 0, 613
Remote Config [candidate] (612.226 µs) : 0, 612
Telemetry [baseline] (8.653 ms) : 0, 8653
Telemetry [candidate] (8.532 ms) : 0, 8532

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.05 s) : 0, 1050090
Total [baseline] (10.513 s) : 0, 10513013
Agent [candidate] (1.042 s) : 0, 1041665
Total [candidate] (10.491 s) : 0, 10490700
section appsec
Agent [baseline] (1.185 s) : 0, 1184768
Total [baseline] (10.716 s) : 0, 10716277
Agent [candidate] (1.186 s) : 0, 1186486
Total [candidate] (10.786 s) : 0, 10786299
section iast
Agent [baseline] (1.174 s) : 0, 1174061
Total [baseline] (11.0 s) : 0, 10999716
Agent [candidate] (1.171 s) : 0, 1171031
Total [candidate] (10.964 s) : 0, 10964021
section profiling
Agent [baseline] (1.272 s) : 0, 1271874
Total [baseline] (10.901 s) : 0, 10901091
Agent [candidate] (1.264 s) : 0, 1263767
Total [candidate] (10.861 s) : 0, 10860725

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.05 s	-
Agent	appsec	1.185 s	134.679 ms (12.8%)
Agent	iast	1.174 s	123.971 ms (11.8%)
Agent	profiling	1.272 s	221.784 ms (21.1%)
Total	tracing	10.513 s	-
Total	appsec	10.716 s	203.265 ms (1.9%)
Total	iast	11.0 s	486.704 ms (4.6%)
Total	profiling	10.901 s	388.078 ms (3.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.186 s	144.821 ms (13.9%)
Agent	iast	1.171 s	129.366 ms (12.4%)
Agent	profiling	1.264 s	222.102 ms (21.3%)
Total	tracing	10.491 s	-
Total	appsec	10.786 s	295.599 ms (2.8%)
Total	iast	10.964 s	473.321 ms (4.5%)
Total	profiling	10.861 s	370.024 ms (3.5%)

gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (721.114 ms) : 0, 721114
BytebuddyAgent [candidate] (714.909 ms) : 0, 714909
GlobalTracer [baseline] (243.429 ms) : 0, 243429
GlobalTracer [candidate] (243.766 ms) : 0, 243766
AppSec [baseline] (55.152 ms) : 0, 55152
AppSec [candidate] (55.534 ms) : 0, 55534
Remote Config [baseline] (716.56 µs) : 0, 717
Remote Config [candidate] (725.806 µs) : 0, 726
Telemetry [baseline] (14.454 ms) : 0, 14454
Telemetry [candidate] (11.541 ms) : 0, 11541
section appsec
BytebuddyAgent [baseline] (732.938 ms) : 0, 732938
BytebuddyAgent [candidate] (734.454 ms) : 0, 734454
GlobalTracer [baseline] (240.553 ms) : 0, 240553
GlobalTracer [candidate] (240.35 ms) : 0, 240350
AppSec [baseline] (176.289 ms) : 0, 176289
AppSec [candidate] (176.778 ms) : 0, 176778
Remote Config [baseline] (654.066 µs) : 0, 654
Remote Config [candidate] (657.551 µs) : 0, 658
Telemetry [baseline] (8.284 ms) : 0, 8284
Telemetry [candidate] (8.28 ms) : 0, 8280
IAST [baseline] (21.621 ms) : 0, 21621
IAST [candidate] (21.425 ms) : 0, 21425
section iast
BytebuddyAgent [baseline] (835.968 ms) : 0, 835968
BytebuddyAgent [candidate] (833.571 ms) : 0, 833571
GlobalTracer [baseline] (233.87 ms) : 0, 233870
GlobalTracer [candidate] (233.692 ms) : 0, 233692
AppSec [baseline] (54.652 ms) : 0, 54652
AppSec [candidate] (53.564 ms) : 0, 53564
Remote Config [baseline] (700.337 µs) : 0, 700
Remote Config [candidate] (616.696 µs) : 0, 617
Telemetry [baseline] (8.707 ms) : 0, 8707
Telemetry [candidate] (8.731 ms) : 0, 8731
IAST [baseline] (24.969 ms) : 0, 24969
IAST [candidate] (25.619 ms) : 0, 25619
section profiling
BytebuddyAgent [baseline] (711.713 ms) : 0, 711713
BytebuddyAgent [candidate] (705.769 ms) : 0, 705769
GlobalTracer [baseline] (355.041 ms) : 0, 355041
GlobalTracer [candidate] (354.27 ms) : 0, 354270
AppSec [baseline] (55.435 ms) : 0, 55435
AppSec [candidate] (54.836 ms) : 0, 54836
Remote Config [baseline] (722.179 µs) : 0, 722
Remote Config [candidate] (719.713 µs) : 0, 720
Telemetry [baseline] (9.063 ms) : 0, 9063
Telemetry [candidate] (9.053 ms) : 0, 9053
ProfilingAgent [baseline] (97.302 ms) : 0, 97302
ProfilingAgent [candidate] (96.858 ms) : 0, 96858
Profiling [baseline] (97.329 ms) : 0, 97329
Profiling [candidate] (96.884 ms) : 0, 96884

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-02-04T16:14:14	2025-02-04T16:21:22
git_branch	master	daniel.mohedano/test-management-setting
git_commit_date	1738664773	1738684695
git_commit_sha	`b9533be`	`e78edfa`
release_version	1.47.0-SNAPSHOT~b9533be551	1.47.0-SNAPSHOT~e78edfa92c
start_time	2025-02-04T16:14:00	2025-02-04T16:21:07

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738686442	1738686442
ci_job_id	793507859	793507859
ci_pipeline_id	54858573	54858573
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-fdzndate-project-304-concurrent-4-eq3h295g 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-fdzndate-project-304-concurrent-4-eq3h295g 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 13 metrics, 15 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.354 ms) : 1335, 1373
.   : milestone, 1354,
appsec (1.777 ms) : 1752, 1803
.   : milestone, 1777,
appsec_no_iast (1.763 ms) : 1738, 1787
.   : milestone, 1763,
iast (1.534 ms) : 1509, 1559
.   : milestone, 1534,
profiling (1.521 ms) : 1497, 1545
.   : milestone, 1521,
tracing (1.523 ms) : 1498, 1548
.   : milestone, 1523,
section candidate
no_agent (1.351 ms) : 1332, 1370
.   : milestone, 1351,
appsec (1.765 ms) : 1741, 1789
.   : milestone, 1765,
appsec_no_iast (1.756 ms) : 1731, 1782
.   : milestone, 1756,
iast (1.523 ms) : 1498, 1548
.   : milestone, 1523,
profiling (1.523 ms) : 1500, 1547
.   : milestone, 1523,
tracing (1.496 ms) : 1471, 1521
.   : milestone, 1496,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.354 ms [1.335 ms, 1.373 ms]	-
appsec	1.777 ms [1.752 ms, 1.803 ms]	423.461 µs (31.3%)
appsec_no_iast	1.763 ms [1.738 ms, 1.787 ms]	408.634 µs (30.2%)
iast	1.534 ms [1.509 ms, 1.559 ms]	179.936 µs (13.3%)
profiling	1.521 ms [1.497 ms, 1.545 ms]	167.064 µs (12.3%)
tracing	1.523 ms [1.498 ms, 1.548 ms]	169.007 µs (12.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.332 ms, 1.37 ms]	-
appsec	1.765 ms [1.741 ms, 1.789 ms]	413.695 µs (30.6%)
appsec_no_iast	1.756 ms [1.731 ms, 1.782 ms]	405.208 µs (30.0%)
iast	1.523 ms [1.498 ms, 1.548 ms]	171.946 µs (12.7%)
profiling	1.523 ms [1.5 ms, 1.547 ms]	172.334 µs (12.8%)
tracing	1.496 ms [1.471 ms, 1.521 ms]	144.901 µs (10.7%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551
    dateFormat X
    axisFormat %s
section baseline
no_agent (383.23 µs) : 362, 404
.   : milestone, 383,
iast (513.352 µs) : 491, 535
.   : milestone, 513,
iast_FULL (751.994 µs) : 729, 775
.   : milestone, 752,
iast_GLOBAL (573.771 µs) : 550, 598
.   : milestone, 574,
iast_HARDCODED_SECRET_DISABLED (514.326 µs) : 493, 536
.   : milestone, 514,
iast_INACTIVE (472.702 µs) : 450, 495
.   : milestone, 473,
iast_TELEMETRY_OFF (501.291 µs) : 479, 524
.   : milestone, 501,
tracing (463.973 µs) : 443, 485
.   : milestone, 464,
section candidate
no_agent (386.953 µs) : 367, 407
.   : milestone, 387,
iast (521.461 µs) : 499, 544
.   : milestone, 521,
iast_FULL (759.848 µs) : 738, 782
.   : milestone, 760,
iast_GLOBAL (558.385 µs) : 537, 580
.   : milestone, 558,
iast_HARDCODED_SECRET_DISABLED (515.362 µs) : 493, 537
.   : milestone, 515,
iast_INACTIVE (459.561 µs) : 438, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (505.899 µs) : 483, 528
.   : milestone, 506,
tracing (456.329 µs) : 436, 477
.   : milestone, 456,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.23 µs [362.488 µs, 403.973 µs]	-
iast	513.352 µs [491.32 µs, 535.384 µs]	130.122 µs (34.0%)
iast_FULL	751.994 µs [729.294 µs, 774.693 µs]	368.763 µs (96.2%)
iast_GLOBAL	573.771 µs [549.73 µs, 597.812 µs]	190.541 µs (49.7%)
iast_HARDCODED_SECRET_DISABLED	514.326 µs [492.698 µs, 535.954 µs]	131.096 µs (34.2%)
iast_INACTIVE	472.702 µs [450.38 µs, 495.025 µs]	89.472 µs (23.3%)
iast_TELEMETRY_OFF	501.291 µs [478.806 µs, 523.776 µs]	118.061 µs (30.8%)
tracing	463.973 µs [442.549 µs, 485.396 µs]	80.742 µs (21.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	386.953 µs [367.13 µs, 406.776 µs]	-
iast	521.461 µs [499.16 µs, 543.762 µs]	134.509 µs (34.8%)
iast_FULL	759.848 µs [737.936 µs, 781.76 µs]	372.895 µs (96.4%)
iast_GLOBAL	558.385 µs [537.039 µs, 579.731 µs]	171.432 µs (44.3%)
iast_HARDCODED_SECRET_DISABLED	515.362 µs [493.388 µs, 537.335 µs]	128.409 µs (33.2%)
iast_INACTIVE	459.561 µs [438.469 µs, 480.654 µs]	72.608 µs (18.8%)
iast_TELEMETRY_OFF	505.899 µs [483.399 µs, 528.399 µs]	118.946 µs (30.7%)
tracing	456.329 µs [435.704 µs, 476.954 µs]	69.376 µs (17.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	daniel.mohedano/test-management-setting
git_commit_date	1738664773	1738684695
git_commit_sha	`b9533be`	`e78edfa`
release_version	1.47.0-SNAPSHOT~b9533be551	1.47.0-SNAPSHOT~e78edfa92c

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738686989	1738686989
ci_job_id	793507860	793507860
ci_pipeline_id	54858573	54858573
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-fdzndate-project-304-concurrent-5-kixzf0n2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-fdzndate-project-304-concurrent-5-kixzf0n2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
appsec (15.216 s) : 15216000, 15216000
.   : milestone, 15216000,
iast (19.0 s) : 19000000, 19000000
.   : milestone, 19000000,
iast_GLOBAL (18.057 s) : 18057000, 18057000
.   : milestone, 18057000,
profiling (15.713 s) : 15713000, 15713000
.   : milestone, 15713000,
tracing (15.356 s) : 15356000, 15356000
.   : milestone, 15356000,
section candidate
no_agent (15.147 s) : 15147000, 15147000
.   : milestone, 15147000,
appsec (15.256 s) : 15256000, 15256000
.   : milestone, 15256000,
iast (18.689 s) : 18689000, 18689000
.   : milestone, 18689000,
iast_GLOBAL (18.007 s) : 18007000, 18007000
.   : milestone, 18007000,
profiling (15.038 s) : 15038000, 15038000
.   : milestone, 15038000,
tracing (14.891 s) : 14891000, 14891000
.   : milestone, 14891000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.953 s [14.953 s, 14.953 s]	-
appsec	15.216 s [15.216 s, 15.216 s]	263.0 ms (1.8%)
iast	19.0 s [19.0 s, 19.0 s]	4.047 s (27.1%)
iast_GLOBAL	18.057 s [18.057 s, 18.057 s]	3.104 s (20.8%)
profiling	15.713 s [15.713 s, 15.713 s]	760.0 ms (5.1%)
tracing	15.356 s [15.356 s, 15.356 s]	403.0 ms (2.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.147 s [15.147 s, 15.147 s]	-
appsec	15.256 s [15.256 s, 15.256 s]	109.0 ms (0.7%)
iast	18.689 s [18.689 s, 18.689 s]	3.542 s (23.4%)
iast_GLOBAL	18.007 s [18.007 s, 18.007 s]	2.86 s (18.9%)
profiling	15.038 s [15.038 s, 15.038 s]	-109.0 ms (-0.7%)
tracing	14.891 s [14.891 s, 14.891 s]	-256.0 ms (-1.7%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~e78edfa92c, baseline=1.47.0-SNAPSHOT~b9533be551
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.478 ms) : 1466, 1489
.   : milestone, 1478,
appsec (2.375 ms) : 2331, 2418
.   : milestone, 2375,
iast (2.117 ms) : 2062, 2171
.   : milestone, 2117,
iast_GLOBAL (2.157 ms) : 2102, 2212
.   : milestone, 2157,
profiling (2.475 ms) : 2289, 2660
.   : milestone, 2475,
tracing (1.955 ms) : 1913, 1998
.   : milestone, 1955,
section candidate
no_agent (1.474 ms) : 1462, 1485
.   : milestone, 1474,
appsec (2.358 ms) : 2315, 2402
.   : milestone, 2358,
iast (2.133 ms) : 2078, 2188
.   : milestone, 2133,
iast_GLOBAL (2.154 ms) : 2099, 2209
.   : milestone, 2154,
profiling (1.98 ms) : 1936, 2023
.   : milestone, 1980,
tracing (1.951 ms) : 1908, 1993
.   : milestone, 1951,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.478 ms [1.466 ms, 1.489 ms]	-
appsec	2.375 ms [2.331 ms, 2.418 ms]	897.128 µs (60.7%)
iast	2.117 ms [2.062 ms, 2.171 ms]	638.903 µs (43.2%)
iast_GLOBAL	2.157 ms [2.102 ms, 2.212 ms]	679.044 µs (46.0%)
profiling	2.475 ms [2.289 ms, 2.66 ms]	996.986 µs (67.5%)
tracing	1.955 ms [1.913 ms, 1.998 ms]	477.741 µs (32.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.474 ms [1.462 ms, 1.485 ms]	-
appsec	2.358 ms [2.315 ms, 2.402 ms]	884.506 µs (60.0%)
iast	2.133 ms [2.078 ms, 2.188 ms]	659.483 µs (44.7%)
iast_GLOBAL	2.154 ms [2.099 ms, 2.209 ms]	680.059 µs (46.1%)
profiling	1.98 ms [1.936 ms, 2.023 ms]	505.976 µs (34.3%)
tracing	1.951 ms [1.908 ms, 1.993 ms]	477.004 µs (32.4%)

nikita-tkachenko-datadog · 2025-02-04T11:21:58Z

...visibility/src/main/java/datadog/trace/civisibility/config/ExecutionSettingsFactoryImpl.java

+      Function<Integer, Boolean> overrideCheck,
+      Consumer<Integer> overrideAction) {
+    Integer value = valueGetter.apply(config);
+    if (value != null && overrideCheck.apply(value)) {


I understand that we want to apply the overriding local value only if it's different from the -1 default, but the function is so generic that it's takes a bit of effort to comprehend.
Perhaps we could make the Config field Integer instead of int, and apply the override if the value is not null, dropping the overrideCheck?

I thought having a very generic way of overriding values might be beneficial in the future, but it might not make much sense for now as it is only used in this specific scenario. Overriding (or, better yet, creating a new instance as the next comment indicates) would be much clearer if the Config field was an Integer with null as default, I agree

nikita-tkachenko-datadog · 2025-02-04T11:24:28Z

...nt-ci-visibility/src/main/java/datadog/trace/civisibility/config/TestManagementSettings.java

+  public static final TestManagementSettings DEFAULT = new TestManagementSettings(false, -1);
+
+  private final boolean enabled;
+  private int attemptToFixRetries;


I think it'd be better to make the class immutable (marking both fields as final) and create a new instance if there're overrides. Mutability makes it more difficult to reason about the possible outcomes, and has thread-safety implications

nikita-tkachenko-datadog · 2025-02-04T11:29:07Z

...visibility/src/main/java/datadog/trace/civisibility/domain/headless/HeadlessTestSession.java

+
+  @Override
+  public void end(@Nullable Long endTime) {
+    if (executionStrategy.getExecutionSettings().getTestManagementSettings().isEnabled()) {


I'd rather do this via the propagateModuleTags method. Not to say there's much difference, but just for the sake of consistency and to avoid having two different ways of doing the same thing

That'd require setting Tags.TEST_TEST_MANAGEMENT_ENABLED on the module span as well, which you're already doing for the build system module anyway.

True, I agree that it will be more consistent with how the rest of the tags are handled.

nikita-tkachenko-datadog · 2025-02-04T15:36:56Z

...visibility/src/main/java/datadog/trace/civisibility/config/ExecutionSettingsFactoryImpl.java

+        testManagementSettings =
+            new TestManagementSettings(
+                true, config.getCiVisibilityTestManagementAttemptToFixRetries());
+      }


Reassigning the value of the same local variable multiple times is often considered bad practice, as it makes the code harder to comprehend.
I think we can do better if we extract this logic into a separate method (that'd also help to get rid of nested ifs):

@Nonnull private TestManagementSettings getTestManagementSettings(CiVisibilitySettings settings) { boolean testManagementEnabled = isFeatureEnabled( settings, s -> s.getTestManagementSettings().isEnabled(), Config::isCiVisibilityTestManagementEnabled); if (!testManagementEnabled) { return TestManagementSettings.DEFAULT; } Integer retries = config.getCiVisibilityTestManagementAttemptToFixRetries(); if (retries != null) { return new TestManagementSettings(true, retries); } return settings.getTestManagementSettings(); }

...visibility/src/main/java/datadog/trace/civisibility/config/ExecutionSettingsFactoryImpl.java

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.46.1` -> `1.47.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.33` -> `2.30.34` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.47.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.47.0): 1.47.0 ##### Components ##### Application Security Management (IAST) - 🐛 Exclude com.stripe.net.HttpURLConnectionClient to solve IAST SSRF vulnerability false positives ([#8483](DataDog/dd-trace-java#8483) - [@jandro996](https://github.com/jandro996)) - 🐛 Add exclusion to solve IAST weak randomness vulnerability false positives ([#8462](DataDog/dd-trace-java#8462) - [@jandro996](https://github.com/jandro996)) - ✨ Fix weak randomness false positive in Kafka client ([#8408](DataDog/dd-trace-java#8408) - [@smola](https://github.com/smola)) - ✨ Fix location for SSRF with Kong Unirest ([#8407](DataDog/dd-trace-java#8407) - [@smola](https://github.com/smola)) - ✨ Exclude IBM Instana from IAST ([#8406](DataDog/dd-trace-java#8406) - [@smola](https://github.com/smola)) - 🐛 Fix org.json iast instrumentation test for latest dependency ([#8347](DataDog/dd-trace-java#8347) - [@jandro996](https://github.com/jandro996)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) - ✨ Address cookie vulnerability cardinality issues ([#8210](DataDog/dd-trace-java#8210) - [@jandro996](https://github.com/jandro996)) - ✨ Email HTML Injection detection in IAST ([#8205](DataDog/dd-trace-java#8205) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Application Security Management (WAF) - 🐛✨ Ensure usr.exists tag is not overridden when UsernameNotFoundException is thrown ([#8376](DataDog/dd-trace-java#8376) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - 🐛✨ Ensure usr.exists tag is not overridden by auto instrumentation ([#8374](DataDog/dd-trace-java#8374) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update appsec metrics with event_rules_version tag ([#8354](DataDog/dd-trace-java#8354) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) - ✨ Improve ASM support in vert.x 5.0 ([#8285](DataDog/dd-trace-java#8285) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Update metrics: appsec.waf.updates and appsec.waf.init ([#8280](DataDog/dd-trace-java#8280) - [@Mariovido](https://github.com/Mariovido)) - ✨ Configuration to Disable APM Tracing ([#8219](DataDog/dd-trace-java#8219) - [@jandro996](https://github.com/jandro996)) ##### Build & Tooling - 🐛 Do not generate Muzzle references for primitive arrays in method body ([#8361](DataDog/dd-trace-java#8361) - [@amarziali](https://github.com/amarziali)) - 📖 Improve dev env setup documentation for Windows ([#8180](DataDog/dd-trace-java#8180) - [@lucaspimentel](https://github.com/lucaspimentel)) ##### Continuous Integration Visibility - ✨ Add support for skip-EFD tagging ([#8487](DataDog/dd-trace-java#8487) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix an NPE in Gradle Android instrumentation ([#8484](DataDog/dd-trace-java#8484) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Consider modified tests when applying fail-fast tests ordering ([#8474](DataDog/dd-trace-java#8474) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests reordering for TestNG ([#8467](DataDog/dd-trace-java#8467) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Gradle Launcher instrumentation to not interfere with Gradle Test Kit ([#8465](DataDog/dd-trace-java#8465) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Use separate TestEventHandlers per framework in CI Vis instrumentations ([#8451](DataDog/dd-trace-java#8451) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Remove warning log when JUnit 4 test method cannot be retrieved ([#8445](DataDog/dd-trace-java#8445) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix Scalatest tracing for tests that are reported asynchronously ([#8444](DataDog/dd-trace-java#8444) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement attempt to fix tests ([#8393](DataDog/dd-trace-java#8393) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement test disabling ([#8377](DataDog/dd-trace-java#8377) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Update CODEOWNERS parser to not log errors on comments with leading whitespace ([#8349](DataDog/dd-trace-java#8349) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Request Test Management tests list ([#8345](DataDog/dd-trace-java#8345) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Receive test management settings from CIVis settings request ([#8331](DataDog/dd-trace-java#8331) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement quarantined tests tagging ([#8326](DataDog/dd-trace-java#8326) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Implement tests quarantining ([#8320](DataDog/dd-trace-java#8320) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add tag to specify if the user is setting DD_SERVICE ([#8318](DataDog/dd-trace-java#8318) - [@daniel-mohedano](https://github.com/daniel-mohedano)) ##### Crash tracking - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Use Java home of the crashed process to launch crash uploader ([#8348](DataDog/dd-trace-java#8348) - [@jbachorik](https://github.com/jbachorik)) ##### Data Streams Monitoring - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) - 🐛 Fix service name overrides in consumers ([#8387](DataDog/dd-trace-java#8387) - [@piochelepiotr](https://github.com/piochelepiotr)) ##### Database Monitoring - ✨ Add DBMTracePreparedStatements to tracer configuration log ([#8508](DataDog/dd-trace-java#8508) - [@cecile75](https://github.com/cecile75)) ##### Dynamic Instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Fix Exception Replay with Lambda proxy classes ([#8452](DataDog/dd-trace-java#8452) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add support for scanning jar from loaded class ([#8370](DataDog/dd-trace-java#8370) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Disable capture of entry values ([#8369](DataDog/dd-trace-java#8369) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix CodeOrigin for `@Trace` annotation ([#8344](DataDog/dd-trace-java#8344) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix equals/hashCode for CodeOrigin probe ([#8319](DataDog/dd-trace-java#8319) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### Metrics - ✨ Create metric: appsec.waf.error ([#8381](DataDog/dd-trace-java#8381) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Create metric: appsec.rasp.error ([#8364](DataDog/dd-trace-java#8364) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Profiling - ✨ Bump ddprof library to 1.22.0 ([#8463](DataDog/dd-trace-java#8463) - [@jbachorik](https://github.com/jbachorik)) - IBM J9 8u361 corresponds to OpenJDK 8u362 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#187 - Fix compatibility with musl libc 1.2.4 by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#189 - Modify version extraction by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#179 - Do not write null values to jvminfo event by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#184 - Productize VMStructs-based stack walker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#177 - A few minor downport issues by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#180 - Enable ASGCT by default on fairly safe J9 JDK versions by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#181 - 🐛 Exclude OrderedThreadPoolExecutor from queue-time measurements ([#8456](DataDog/dd-trace-java#8456) - [@jbachorik](https://github.com/jbachorik)) - ✨ Record JVM info on JVMs without JFR ([#8431](DataDog/dd-trace-java#8431) - [@jbachorik](https://github.com/jbachorik)) - 🐛 Actually use CleanupTask in TempLocationManager ([#8420](DataDog/dd-trace-java#8420) - [@mcculls](https://github.com/mcculls)) - ✨ Only fork jps when required ([#8419](DataDog/dd-trace-java#8419) - [@mcculls](https://github.com/mcculls)) - 🐛 Adjust JFR checks for J9 ([#8405](DataDog/dd-trace-java#8405) - [@jbachorik](https://github.com/jbachorik)) - 🧹 Disable smap RSS parsing by default ([#8342](DataDog/dd-trace-java#8342) - [@MattAlp](https://github.com/MattAlp)) ##### Telemetry - 🐛 Add support for JBoss jar:file format to DependencyResolver ([#8428](DataDog/dd-trace-java#8428) - [@jandro996](https://github.com/jandro996)) - ✨ Update metrics: appsec.waf.requests ([#8353](DataDog/dd-trace-java#8353) - [@Mariovido](https://github.com/Mariovido)) ##### Trace context propagation - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - 🐛 Fix Stable Config telemetry source names ([#8460](DataDog/dd-trace-java#8460) - [@BaptisteFoy](https://github.com/BaptisteFoy)) - ✨ Probe trace endpoints with a valid payload of empty arrays ([#8414](DataDog/dd-trace-java#8414) - [@mcculls](https://github.com/mcculls)) - ✨ Add 1 minute fail-safe to JUL/JMX class-loading callback ([#8399](DataDog/dd-trace-java#8399) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate DSM injection calls to context-first APIs ([#8383](DataDog/dd-trace-java#8383) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Move continuation capture methods from scope to tracer ([#8371](DataDog/dd-trace-java#8371) - [@mcculls](https://github.com/mcculls)) - ✨ Migrate context extraction calls to context-first APIs ([#8368](DataDog/dd-trace-java#8368) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 🧹 Migrate context injection calls to context-first APIs ([#8358](DataDog/dd-trace-java#8358) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - 💡 Support reading configurations from files ([#8338](DataDog/dd-trace-java#8338) - [@mtoffl01](https://github.com/mtoffl01)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - 🧹 Combine continuation implementations into one which supports multiple activations ([#8324](DataDog/dd-trace-java#8324) - [@mcculls](https://github.com/mcculls)) - ✨ Introduce tracing propagator ([#8313](DataDog/dd-trace-java#8313) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Remove old context propagation API ([#8271](DataDog/dd-trace-java#8271) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Instrumentations ##### AWS Lambda instrumentation - 🐛 Send error message and stack to Lambda extension ([#8417](DataDog/dd-trace-java#8417) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Fix error happening when sqs message attributes are readonly ([#8473](DataDog/dd-trace-java#8473) - [@vandonr](https://github.com/vandonr)) - 💡 Inject trace context into AWS Step Functions input ([#7585](DataDog/dd-trace-java#7585) - [@DylanLovesCoffee](https://github.com/DylanLovesCoffee)) ##### Core Java language instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add code origin support for spring-webmvc ([#8416](DataDog/dd-trace-java#8416) - [@evanchooly](https://github.com/evanchooly)) - 💡 Implementation of BaggagePropagator and BaggageContext ([#8330](DataDog/dd-trace-java#8330) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add code origin support to kafka message listeners ([#8301](DataDog/dd-trace-java#8301) - [@evanchooly](https://github.com/evanchooly)) ##### gRPC instrumentation - ✨ Look in another location for grpc service methods ([#8468](DataDog/dd-trace-java#8468) - [@evanchooly](https://github.com/evanchooly)) ##### Kafka instrumentation - ✨ Add messaging.destination.name tag to kafka integrations ([#8366](DataDog/dd-trace-java#8366) - [@rarguelloF](https://github.com/rarguelloF)) ##### Protocol Buffer instrumentation - 🐛 Fix bug on proto schema extraction ([#8403](DataDog/dd-trace-java#8403) - [@vandonr](https://github.com/vandonr)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 108a0f86aa59ab4c938cbac0688dd4c19cb301fa

daniel-mohedano added 7 commits February 4, 2025 09:40

obtain test management settings from settings request

372c808

add test management telemetry

1397b1a

add test management settings to execution settings

3f1837b

set test management tag if enabled on session end rebase fix

96110c6

formatting fixes

e6028c5

move test management check to isQuarantined

97d9ca1

update test fixtures to use test management

8d43f9d

daniel-mohedano added comp: ci visibility Continuous Integration Visibility type: enhancement labels Feb 4, 2025

daniel-mohedano requested a review from nikita-tkachenko-datadog February 4, 2025 10:04

nikita-tkachenko-datadog reviewed Feb 4, 2025

View reviewed changes

daniel-mohedano added 2 commits February 4, 2025 15:42

propagate test management tag from headless module to session

73a3b86

make test management settings immutable and update retries override

bd2aa39

nikita-tkachenko-datadog reviewed Feb 4, 2025

View reviewed changes

...visibility/src/main/java/datadog/trace/civisibility/config/ExecutionSettingsFactoryImpl.java Outdated Show resolved Hide resolved

refactor test management overriding logic

e78edfa

nikita-tkachenko-datadog approved these changes Feb 4, 2025

View reviewed changes

daniel-mohedano marked this pull request as ready for review February 5, 2025 08:16

daniel-mohedano requested review from a team as code owners February 5, 2025 08:16

daniel-mohedano requested review from tonyredondo and smola February 5, 2025 08:16

daniel-mohedano merged commit ac2ce26 into master Feb 5, 2025
197 checks passed

daniel-mohedano deleted the daniel.mohedano/test-management-setting branch February 5, 2025 09:26

github-actions bot added this to the 1.47.0 milestone Feb 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Receive test management settings from CIVis settings request #8331

Receive test management settings from CIVis settings request #8331

daniel-mohedano commented Feb 4, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Feb 4, 2025 •

edited

Loading

nikita-tkachenko-datadog Feb 4, 2025

daniel-mohedano Feb 4, 2025

nikita-tkachenko-datadog Feb 4, 2025

nikita-tkachenko-datadog Feb 4, 2025

nikita-tkachenko-datadog Feb 4, 2025

daniel-mohedano Feb 4, 2025

nikita-tkachenko-datadog Feb 4, 2025 •

edited

Loading

Receive test management settings from CIVis settings request #8331

Receive test management settings from CIVis settings request #8331

Conversation

daniel-mohedano commented Feb 4, 2025 • edited by jira bot Loading

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter bot commented Feb 4, 2025 • edited Loading

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

nikita-tkachenko-datadog Feb 4, 2025

Choose a reason for hiding this comment

daniel-mohedano Feb 4, 2025

Choose a reason for hiding this comment

nikita-tkachenko-datadog Feb 4, 2025

Choose a reason for hiding this comment

nikita-tkachenko-datadog Feb 4, 2025

Choose a reason for hiding this comment

nikita-tkachenko-datadog Feb 4, 2025

Choose a reason for hiding this comment

daniel-mohedano Feb 4, 2025

Choose a reason for hiding this comment

nikita-tkachenko-datadog Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

daniel-mohedano commented Feb 4, 2025 •

edited by jira bot

Loading

pr-commenter bot commented Feb 4, 2025 •

edited

Loading

nikita-tkachenko-datadog Feb 4, 2025 •

edited

Loading