Port to TypeScript #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in better size and style matching with "o" for open strings.
* bridge-width: Account for stroke width when drawing bridge
* mute-alignment: Manually draw "x" for muted strings
* fret-position-label: Fix fret position label, especially at small sizes
|
Thanks for all these changes, much appreciated. It's been a long time since this repo's been updated, and I'll merged your changes in. |
|
If you're interested, I can add you as a collaborator to this repo, so you can merge them in directly. LMK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
These changes depend on my previously opened PRs (#49, #50, #51, #52). Since it looks like this library is no longer maintained, I'll be maintaining a fork with all my improvements at chordbook/vexchords.
This ports the library to TypeScript with as few other changes as possible.
Fixes #43