Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace webpacker with vite #51

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace webpacker with vite #51

wants to merge 2 commits into from

Conversation

bkeepers
Copy link
Contributor

@bkeepers bkeepers commented Dec 24, 2024

I couldn't get the outdated version of webpack-dev-server running locally. This replaces it with vite, which is a much more modern tool built on top of esbuild. I also couldn't get the old eslint running. I didn't see anywhere it was being used, so I just updated to the latest version using the default config.

A note on commands:

  • npm start still runs the demo in development mode
  • npm run build still builds the library (so npm publish just works)
  • npm run build:demo will build the demo for publishing
  • npm run lint will run eslint

Note

I know this library has been stagnant for a while, so I'm not sure if my recent PRs will be merged or not. In the meantime, I'll be maintaining a fork with all my improvements at chordbook/vexchords.

@bkeepers bkeepers mentioned this pull request Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant