Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show all atoms data #639

Merged
merged 9 commits into from
Aug 28, 2024
Merged

show all atoms data #639

merged 9 commits into from
Aug 28, 2024

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Aug 27, 2024

This PR improves which data can be visualized in the GUI

  • update all plotting tools to use metadata correctly.
  • update the readme with the new features
  • do not jump to None or undefined

@codecov-commenter
Copy link

codecov-commenter commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 25.27473% with 68 lines in your changes missing coverage. Please review.

Project coverage is 54.41%. Comparing base (684e781) to head (f64465e).

Files Patch % Lines
zndraw/analyse/__init__.py 17.80% 60 Missing ⚠️
zndraw/scene.py 30.00% 7 Missing ⚠️
zndraw/utils.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   55.72%   54.41%   -1.32%     
==========================================
  Files          35       35              
  Lines        2848     2913      +65     
==========================================
- Hits         1587     1585       -2     
- Misses       1261     1328      +67     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PythonFZ PythonFZ marked this pull request as ready for review August 28, 2024 08:04
@PythonFZ PythonFZ merged commit 84cb793 into main Aug 28, 2024
4 checks passed
@PythonFZ PythonFZ deleted the display-all-atom-data branch August 28, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants