Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

single zndraw config API #609

Merged
merged 17 commits into from
Aug 12, 2024
Merged

single zndraw config API #609

merged 17 commits into from
Aug 12, 2024

Conversation

PythonFZ
Copy link
Member

@PythonFZ PythonFZ commented Aug 9, 2024

combine Scene and Arrow config API to be united in vis.config

  • enable UI changes again
  • update UI elements via schema (can also e.g. append to dropdowns so preferred over setValue)

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 40 lines in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (0ecde2b) to head (198a104).

Files Patch % Lines
tests/test_config.py 40.62% 19 Missing ⚠️
zndraw/server/events.py 29.16% 17 Missing ⚠️
zndraw/utils.py 77.77% 2 Missing ⚠️
zndraw/scene.py 94.11% 1 Missing ⚠️
zndraw/zndraw.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #609      +/-   ##
==========================================
+ Coverage   54.65%   56.53%   +1.88%     
==========================================
  Files          33       34       +1     
  Lines        2644     2722      +78     
==========================================
+ Hits         1445     1539      +94     
+ Misses       1199     1183      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PythonFZ PythonFZ merged commit a14ea67 into main Aug 12, 2024
4 checks passed
@PythonFZ PythonFZ deleted the zndraw-config-update branch August 12, 2024 09:54
@PythonFZ PythonFZ mentioned this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants