Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vectorfield variables #585

Merged
merged 2 commits into from
Aug 2, 2024
Merged

Fix vectorfield variables #585

merged 2 commits into from
Aug 2, 2024

Conversation

phohenberger
Copy link
Collaborator

@phohenberger phohenberger commented Aug 2, 2024

This seems to fix some errors with the vectorfield I have been encountering

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.68%. Comparing base (37c658b) to head (eb3a854).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
- Coverage   54.73%   54.68%   -0.05%     
==========================================
  Files          31       31              
  Lines        2346     2346              
==========================================
- Hits         1284     1283       -1     
- Misses       1062     1063       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phohenberger
Copy link
Collaborator Author

To be on the safe side, one could also use something like [start, end, scale_vector_thickness, colormap, colorrange] to ensure everything gets updated when changed. However the updates with colormap etc, also directly applied when just using [start, end]

@phohenberger phohenberger requested a review from PythonFZ August 2, 2024 09:50
Copy link
Member

@PythonFZ PythonFZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Funny bug, but great if this fixes it.

@PythonFZ PythonFZ merged commit 753b56b into main Aug 2, 2024
4 checks passed
@PythonFZ PythonFZ deleted the fix-vectorfields-again branch August 2, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants