completed tests rearrangement #812
Conversation
Now all tests are following the structure proposed in sisl-files #14. It means complete output storage, and cherry-picks for the files to be tested. This of course meant a huge restructuring of tests since tests had to be redone, re-arranged etc. In particular, we have changed the tbtrans test to be much smaller, and hence that particular test is much faster! Signed-off-by: Nick Papior <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| assert orb_left[d1, d2.T].sum() == pytest.approx(-orb_left[d2, d1.T].sum()) | ||
| assert orb_right[d2, d1.T].sum() == pytest.approx(tbt.transmission(right, left)[E]) | ||
| assert orb_right[d2, d1.T].sum() == pytest.approx(-orb_right[d1, d2.T].sum()) | ||
| d1 = geom.a2o(range(6, 12), all=True).reshape(-1, 1) |
Check notice
Code scanning / CodeQL
Unused local variable Note test
| assert orb_right[d2, d1.T].sum() == pytest.approx(tbt.transmission(right, left)[E]) | ||
| assert orb_right[d2, d1.T].sum() == pytest.approx(-orb_right[d1, d2.T].sum()) | ||
| d1 = geom.a2o(range(6, 12), all=True).reshape(-1, 1) | ||
| d2 = geom.a2o(range(12, 18), all=True).reshape(-1, 1) |
Check notice
Code scanning / CodeQL
Unused local variable Note test
|
|
||
|
|
||
| def test_si_ion_xml_handle(sisl_files): | ||
| f = open(sisl_files(_dir, "Si.ion.xml"), "r") | ||
| f = open(sisl_files("siesta", "Si_pdos_k", "Si.ion.xml"), "r") |
Check warning
Code scanning / CodeQL
File is not always closed Warning test
|
|
||
|
|
||
| def test_si_ion_xml_stringio(sisl_files): | ||
| f = StringIO(open(sisl_files(_dir, "Si.ion.xml"), "r").read()) | ||
| f = StringIO(open(sisl_files("siesta", "Si_pdos_k", "Si.ion.xml"), "r").read()) |
Check warning
Code scanning / CodeQL
File is not always closed Warning test
Now all tests are following the structure
proposed in zerothi/sisl-files#14.
It means complete output storage, and
cherry-picks for the files to be tested.
This of course meant a huge restructuring of tests since tests had to be redone, re-arranged etc.
In particular, we have changed the tbtrans test
to be much smaller, and hence that particular
test is much faster!