enabled vacuum for all geometries with non-pbc directions #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a long saught solution to fix vacuum lengths by enabling users to control them. Signed-off-by: Nick Papior <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #809 +/- ##
==========================================
+ Coverage 87.09% 87.10% +0.01%
==========================================
Files 401 401
Lines 51830 51875 +45
==========================================
+ Hits 45140 45185 +45
Misses 6690 6690 ☔ View full report in Codecov by Sentry. |
|
Looks good to me! |
|
Yes, looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long saught solution to fix vacuum lengths by enabling users to control them.
@tfrederiksen @pfebrer I hope this covers everything, without breaking stuff...
I don't know if this should be moved to the
_common.pyfile, perhaps it should... Well...Let me know if this is ok, as is, or something is not covered.