Add support for sisl in nodify's GUI #776
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def _get_plot_options(file_name: str) -> List[str]: | ||
| try: | ||
| plot_handler = sisl.get_sile(file_name).plot | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
|
|
||
| try: | ||
| plot.get() | ||
| except: |
Check notice
Code scanning / CodeQL
Except block handles 'BaseException' Note
|
|
||
| try: | ||
| plot.get() | ||
| except: |
Check notice
Code scanning / CodeQL
Empty except Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
==========================================
- Coverage 87.34% 87.30% -0.04%
==========================================
Files 393 394 +1
Lines 50385 50409 +24
==========================================
+ Hits 44007 44011 +4
- Misses 6378 6398 +20 ☔ View full report in Codecov by Sentry. |
The idea is that
sisl-gui(https://github.com/pfebrer/sisl-gui) will disappear in favour of a GUI that is general fornodify. This GUI can be launched in the terminal withonce
nodifyis installed.Then, the only thing sisl-specific (for now) are the options that sisl provides for plotting files. These are registered once
sislis nodified, becausesisl.__nodify__()will be called.Then, to use sisl functionality on
nodify's GUI one only needs to pass sisl on the list of modules:This will result in what previously was
sisl-gui.