-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for reading Hamiltonian from wannier90 output #723
add test for reading Hamiltonian from wannier90 output #723
Conversation
Once the other PR is merged, then you should bump the files submodule in this PR as well. :) Thanks! |
I don't think I understand what you mean by this. |
The cd <root sisl folder>
git submodule init # if files doesn't already exist and is populated
cd files
git pull
cd ..
git add files |
think of the |
I am not sure, why this is showing a merge conflict now. Maybe I went wrong in updating the submodule? |
I'll amend to this branch to try and fix it... I can't immediately see what went wrong, I'll ping you, thanks! |
3e86491
to
69a1343
Compare
Signed-off-by: Nick Papior <[email protected]>
It was because your branch was way behind |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #723 +/- ##
==========================================
+ Coverage 86.64% 86.82% +0.17%
==========================================
Files 399 399
Lines 50816 50823 +7
==========================================
+ Hits 44030 44125 +95
+ Misses 6786 6698 -88 ☔ View full report in Codecov by Sentry. |
Add test for the reading of Wannier90 Hamiltonian in sisl. See related PR in sisl-files repo (sisl-files #11).