Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for reading Hamiltonian from wannier90 output #723

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

nils-wittemeier
Copy link
Contributor

Add test for the reading of Wannier90 Hamiltonian in sisl. See related PR in sisl-files repo (sisl-files #11).

@zerothi
Copy link
Owner

zerothi commented Mar 21, 2024

Once the other PR is merged, then you should bump the files submodule in this PR as well. :)

Thanks!

@nils-wittemeier
Copy link
Contributor Author

bump the files submodule in this PR as well.

I don't think I understand what you mean by this.

@zerothi
Copy link
Owner

zerothi commented Mar 21, 2024

The files folder is a submodule (git-terminology).
So you should do something like this:

cd <root sisl folder>
git submodule init # if files doesn't already exist and is populated
cd files
git pull
cd ..
git add files

@zerothi
Copy link
Owner

zerothi commented Mar 21, 2024

think of the files submodule as a regular file in the repo

@nils-wittemeier
Copy link
Contributor Author

I am not sure, why this is showing a merge conflict now.

Maybe I went wrong in updating the submodule?

@zerothi
Copy link
Owner

zerothi commented Mar 21, 2024

I'll amend to this branch to try and fix it... I can't immediately see what went wrong, I'll ping you, thanks!

@zerothi zerothi force-pushed the wannier90-read-ham-test branch from 3e86491 to 69a1343 Compare March 21, 2024 12:48
Signed-off-by: Nick Papior <[email protected]>
@zerothi
Copy link
Owner

zerothi commented Mar 21, 2024

It was because your branch was way behind main, then the submodule thing has problems. A simple rebase solved the problem.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.82%. Comparing base (53aaa64) to head (0568c12).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
+ Coverage   86.64%   86.82%   +0.17%     
==========================================
  Files         399      399              
  Lines       50816    50823       +7     
==========================================
+ Hits        44030    44125      +95     
+ Misses       6786     6698      -88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit d93919a into zerothi:main Mar 21, 2024
8 checks passed
@nils-wittemeier nils-wittemeier deleted the wannier90-read-ham-test branch March 21, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants