Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed txtSileOrca.no/info.no since it was never present #710

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

zerothi
Copy link
Owner

@zerothi zerothi commented Mar 15, 2024

@tfrederiksen I checked the tests, in none (of the two examples) are the number of basis functions present, will they ever be?
This PR suggests to remove the attribute if it will never be present?
If this is not the case, then please let me know. :)

  • Changes documented in CHANGELOG.md

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (296ace4) to head (4f22ee5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   86.71%   86.72%           
=======================================
  Files         399      399           
  Lines       50659    50662    +3     
=======================================
+ Hits        43931    43935    +4     
+ Misses       6728     6727    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tfrederiksen
Copy link
Contributor

Indeed this info is not included in those two simple examples, but with other flags I've encountered the number of basis functions also in _property.txt. I can supply another example.

@zerothi
Copy link
Owner Author

zerothi commented Mar 15, 2024

ok, it would be great if we could have it in the tests.

If the no is not found, what should sisl do? Raise an error, issue a warning/info. If people need it, I would suspect raising an error would be appropriate?

@tfrederiksen
Copy link
Contributor

ok, it would be great if we could have it in the tests.

OK, see zerothi/sisl-files#8

If the no is not found, what should sisl do? Raise an error, issue a warning/info. If people need it, I would suspect raising an error would be appropriate?

I agree, raising an error seems appropriate.

@zerothi
Copy link
Owner Author

zerothi commented Mar 15, 2024

Ok, will amend this pr

@zerothi
Copy link
Owner Author

zerothi commented Mar 15, 2024

Things should be fixed here.

Signed-off-by: Nick Papior <[email protected]>
@zerothi zerothi merged commit 1bf866e into main Mar 15, 2024
3 checks passed
@zerothi zerothi deleted the txt-remove-no branch March 15, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants