-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed txtSileOrca.no/info.no since it was never present #710
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 86.71% 86.72%
=======================================
Files 399 399
Lines 50659 50662 +3
=======================================
+ Hits 43931 43935 +4
+ Misses 6728 6727 -1 ☔ View full report in Codecov by Sentry. |
Indeed this info is not included in those two simple examples, but with other flags I've encountered the number of basis functions also in |
ok, it would be great if we could have it in the tests. If the |
OK, see zerothi/sisl-files#8
I agree, raising an error seems appropriate. |
Ok, will amend this pr |
Things should be fixed here. |
Signed-off-by: Nick Papior <[email protected]>
Also changed to error when not found. Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
Signed-off-by: Nick Papior <[email protected]>
@tfrederiksen I checked the tests, in none (of the two examples) are the number of basis functions present, will they ever be?
This PR suggests to remove the attribute if it will never be present?
If this is not the case, then please let me know. :)
CHANGELOG.md