Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading of the viz module #692

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Lazy loading of the viz module #692

merged 1 commit into from
Feb 28, 2024

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Feb 26, 2024

  • Closes sisl.viz lazily loaded #690
  • Added tests for new/changed functions?
  • Ran isort . and black . [24.2.0] at top-level
  • Documentation for functionality in docs/
  • Changes documented in CHANGELOG.md

As proposed in #690, now the sisl module is lazily loaded, so no need for explicitly importing sisl.viz or the existence of the SISL_VIZ_AUTOLOAD variable anymore.

I updated the documentation accordingly.

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 75.68%. Comparing base (02f931e) to head (c31b395).

Files Patch % Lines
src/sisl/_lazy_viz.py 76.47% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #692   +/-   ##
=======================================
  Coverage   75.68%   75.68%           
=======================================
  Files         397      398    +1     
  Lines       50393    50418   +25     
=======================================
+ Hits        38139    38161   +22     
- Misses      12254    12257    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi
Copy link
Owner

zerothi commented Feb 28, 2024

Thanks!

@zerothi zerothi merged commit 2836e38 into zerothi:main Feb 28, 2024
8 checks passed
@pfebrer pfebrer deleted the lazy_viz branch March 15, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sisl.viz lazily loaded
2 participants