Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tweaks to atom colors #684

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Some tweaks to atom colors #684

merged 1 commit into from
Feb 19, 2024

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Feb 19, 2024

This PR adds some changes to atom colors:

  • There is one base class AtomColors, which you can subclass to provide a given color palette. What previously was AtomDefaultColors is now JMolColors. So now there is room for other color palettes.
  • The hydrogen atom color was set to pure white, which was invisible on a white background. Now it is a pale shade of gray.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f9b4dc) 85.78% compared to head (317ca3d) 85.77%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   85.78%   85.77%   -0.01%     
==========================================
  Files         367      367              
  Lines       43904    43917      +13     
==========================================
+ Hits        37662    37669       +7     
- Misses       6242     6248       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerothi zerothi merged commit e78ef89 into zerothi:main Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants