Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: reading the EDM from fdf did not read geometry automatically #526

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Jan 17, 2023

fdf was not an option for reading the geometry when reading the energy density matrix.

@zerothi zerothi merged commit 62bfe10 into zerothi:main Jan 17, 2023
@zerothi
Copy link
Owner

zerothi commented Jan 17, 2023

I have also added this possibility for the TSHS and overlap matrix. It shouldn't be necessary since the TSHS file always contain the geometry, however, it seems weird to not have it when the others are present.

Thanks!

@pfebrer
Copy link
Contributor Author

pfebrer commented Jan 17, 2023

Does the TSHS contain all the basis information?

@zerothi
Copy link
Owner

zerothi commented Jan 17, 2023

No, I plan on deprecating the TSHS file since the newest hsx file contains everything the tshs file contained, plus basis information. So it should be superfluous, I just need to change the electrode blocks to accept hsx files.

@pfebrer
Copy link
Contributor Author

pfebrer commented Jan 17, 2023

Then shouldn't fdf come before TSHS in the order of preference for reading the geometry? (in the DM/EDM I mean)

@pfebrer pfebrer deleted the edm_bug branch January 17, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants