495 deprecation #498
Merged
495 deprecation #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #498 +/- ##
==========================================
+ Coverage 87.26% 87.48% +0.22%
==========================================
Files 353 353
Lines 45709 45208 -501
==========================================
- Hits 39886 39550 -336
+ Misses 5823 5658 -165
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
This pull request introduces 6 alerts when merging 6c80e8d into 3b3ade9 - view on LGTM.com new alerts:
|
|
This pull request introduces 2 alerts when merging 2091ca5 into 53e975c - view on LGTM.com new alerts:
|
zerothi
force-pushed
the
495-deprecation
branch
2 times, most recently
from
394c73d to
6bde28a
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| def dispatch(self, method, eta_key="grid"): | ||
| """ Dispatch the method by putting values on the grid """ | ||
| pool = _pool_procs(self._attrs.get("pool", None)) |
Check notice
Code scanning / CodeQL
Unused local variable
zerothi
force-pushed
the
495-deprecation
branch
2 times, most recently
from
92759be to
071124a
Compare
This means that uses of bz.DOS will have to be changed to wrap the eigenstate. We should consider whether this needs to be eased, possibly with fixing __getattr__.
zerothi
force-pushed
the
495-deprecation
branch
from
071124a to
1d7ff6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all deprecation methods.
This means that older code should update their function calls.