Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: avoid too many matplotlib figures #397

Merged
merged 1 commit into from
Nov 8, 2021
Merged

tests: avoid too many matplotlib figures #397

merged 1 commit into from
Nov 8, 2021

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Nov 8, 2021 •
edited
Loading

Fixes #396

@pfebrer
Copy link
Contributor Author

pfebrer commented Nov 8, 2021

I also moved figure initialization to a separate method so that anyone that wants to subclass MatplotlibBackend can choose how to initialize the figure. (e.g. not use pyplot)

@zerothi zerothi merged commit ecc358e into zerothi:main Nov 8, 2021
@zerothi
Copy link
Owner

zerothi commented Nov 8, 2021

Ok, I think this is acceptable :)

Thanks! I'll try it out immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sisl.viz tests open up *tons* of matplotlib figures
2 participants
@pfebrer @zerothi