Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mnt: fixed matplotlib tests in <=3.4 #378

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Conversation

pfebrer
Copy link
Contributor

@pfebrer pfebrer commented Sep 14, 2021

Solves #377

@codecov
Copy link

codecov bot commented Sep 14, 2021

Codecov Report

Merging #378 (892fe63) into master (8184c75) will increase coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   86.97%   86.98%           
=======================================
  Files         321      321           
  Lines       41752    41759    +7     
=======================================
+ Hits        36313    36323   +10     
+ Misses       5439     5436    -3     
Impacted Files Coverage Δ
sisl/viz/backends/matplotlib/backend.py 57.53% <87.50%> (+2.98%) ⬆️
sisl/io/siesta/out.py 77.42% <0.00%> (+0.47%) ⬆️
sisl/io/gulp/got.py 86.45% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8184c75...892fe63. Read the comment docs.

@zerothi zerothi merged commit 7a9cde9 into zerothi:master Sep 14, 2021
@pfebrer pfebrer deleted the matplotlib_old branch September 16, 2021 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants