Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set “cursor: pointer” on body when inserting click-outside component #13

Conversation

remi
Copy link
Contributor

@remi remi commented Apr 18, 2017

In the latest iOS (and possibly earlier versions), the body element must have cursor: pointer in order for its click event handlers to be triggered when the user clicks on any of its descendants that isn’t itself bound to at least one click event handler.

So, when a component using the ClickOutside mixin is inserted, we set body’s cursor to pointer — otherwise iOS doesn’t send the action.

Let me know if there’s anything I should have done differently 😄

@zeppelin
Copy link
Owner

zeppelin commented May 2, 2017

@remiprev Ah, somehow missed the notification...
Thank you, will review soon!

@zeppelin
Copy link
Owner

zeppelin commented May 5, 2017

@remiprev Could you please rebase & add this._super(...arguments); at the beginning of the lifecycle hooks? Also, it'd be great if the mandatory _super() thing was mentioned in the readme at the mixin section, since now this is required for someone overriding the hooks, but still want to get it working on iOS.

@remi remi force-pushed the feature/set-cursor-pointer-to-body-when-inserting-click-outside-component branch 6 times, most recently from bd12c32 to 9c5e8f1 Compare May 7, 2017 12:17
@remi
Copy link
Contributor Author

remi commented May 7, 2017

@zeppelin Done! 😀

@zeppelin zeppelin merged commit af86be1 into zeppelin:master May 7, 2017
@zeppelin
Copy link
Owner

zeppelin commented May 7, 2017

@remiprev 👍 thanks a lot!

@remi remi deleted the feature/set-cursor-pointer-to-body-when-inserting-click-outside-component branch May 8, 2017 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants