Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support setting 'projectAssets' in 'theme.json' #418

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

canufeel
Copy link

@canufeel canufeel commented Jul 7, 2016

This PR implements a change needed to alter custom theme assets folder name to something else.
The folder name itself in the input and output is mirrored so given public assets folder in the custom theme would result in having public assets folder in the compiled output with all the links inside files set properly.

To set the project assets folder one would need to have something like the following in his theme.json file:

{
    "yuiGridsUrl": "http://yui.yahooapis.com/3.9.1/build/cssgrids/cssgrids-min.css",
    "yuiSeedUrl": "http://yui.yahooapis.com/combo?3.9.1/build/yui/yui-min.js",
    "projectAssets": "public"
}

…' to alter theme assets input and output folder
@yahoocla
Copy link

yahoocla commented Jul 7, 2016

Thank you for submitting this pull request, however I do not see a valid CLA on file for you. Before we can merge this request please visit https://yahoocla.herokuapp.com/ and agree to the terms. Thanks! 😄

@canufeel canufeel closed this Jul 7, 2016
@canufeel canufeel reopened this Jul 7, 2016
@yahoocla
Copy link

yahoocla commented Jul 7, 2016

CLA is valid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants