-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove libvulkan.so from 3P builds and disable linux installer #5205
Conversation
ade6e83
to
eae9f14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be fine, but it might just push our problems til later as it waits to compile the vulkan sources (I'm assuming that angle_shared_libvulkan=false just compiles vulkan as a static library instead of a shlib). I would think there's some flag to ensure we don't depend on vulkan at all.
Regardless, this seems fine to get in and address later, just please have Sherry take a quick look
From the delcaration in third_party/angle/gni/angle.gni i thought it compiles statically only on mac - i might be fully wrong |
My point is that making vulkan compile statically will just make it link later and possibly push the issues to that later linking step instead of removing them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this from Android deps as well actually
ack, will do in a follow up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
8dc1311
to
432883d
Compare
b/406533849