asking for feedback #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavra0
reviewed
Jan 5, 2021
| // kotlin extension has the compilation target that we need to look for to create configurations | ||
| decorateKotlinExtension(project) | ||
| } | ||
| project.pluginManager.withPlugin("com.android.application") { |
There was a problem hiding this comment.
You can check for project.plugins.withType(com.android.build.gradle.api.AndroidBasePlugin) { ... in order to detect all plugin types AGP ships.
There was a problem hiding this comment.
I couldn't use it here because my AGP dependency is compileOnly. That being said, i guess i can reflectively load the class as well.
gavra0
reviewed
Jan 5, 2021
| } | ||
| } | ||
| } | ||
|
|
||
| override fun isApplicable(kotlinCompilation: KotlinCompilation<*>): Boolean = true | ||
|
|
||
| override fun applyToCompilation(kotlinCompilation: KotlinCompilation<*>): Provider<List<SubpluginOption>> { |
There was a problem hiding this comment.
You also need to register generated:
- java sources
- class files
with AGP. See https://github.com/JetBrains/kotlin/blob/41c4693ebf4f394b58a66164ddc206ad82ce1096/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/kapt/Kapt3KotlinGradleSubplugin.kt#L475.
Kotlin sources do not need to registered asn they are anyhow picked up by kotlin compile task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is not a real PR, rather looking for feedback on how to implement KSP sub plugin to properly support android variants.