Update: Enable Workspaces by default but keep the option to turn off #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Summary** Closes #3294 by enabling workspaces by default. **Test plan** Existing tests, slightly modified.
|
NOTE: Tests fail in crazy ways right now. I think the reason is walking up the tree by default to locate workspaces. Will see how I can fix the issue. |
|
Okay, should be ready now. |
arcanis
approved these changes
Aug 25, 2017
joaolucasl
pushed a commit
to joaolucasl/yarn
that referenced
this pull request
Oct 27, 2017
…arnpkg#4262) * Update: Enable Workspaces by default but keep the option to turn off **Summary** Closes yarnpkg#3294 by enabling workspaces by default. **Test plan** Existing tests, slightly modified. * Fix bugz * Update install.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3294 by enabling workspaces by default.
Test plan
Existing tests, slightly modified.