-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Claude Endpoint, introduce Must0 utility, and add tests #69
Refactor Claude Endpoint, introduce Must0 utility, and add tests #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The convention is to have a test file for each go file.
@seungduk-yanolja thank you for the feedback. For the Here is the current code:
What is your recommendation to solve it? Should I change the current code to make it easier to test, or ignore it and write integration test with real API call instead? |
@seungduk-yanolja I updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please capitalize the first letter of the PR title
Summary
This PR does:
Endpoint
implementation to use dependency injection (DI) instead of directly coupling to theanthropic.Client
structEndpoint
Must0
to guarantee not producing errorsMust0