Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dx-improve): Modified docker-compose.yml for smoother deployment #242

Merged
merged 50 commits into from
Jan 23, 2025

Conversation

oindrila-b
Copy link
Contributor

why

In the previous docker-compose, there was no easy way to incorporate the .env file that would later get created, since the image would be pulled from docker-hub and .env was not a part of the docker image. This was changed for smoother deployment.

what changed

  • Added a .env.temp containing temporary .env values for docker-compose to refer to.
  • Modified app container to pull from docker-hub image.
  • Removed environment attributes

test plan

Tested locally

oindrila-b and others added 30 commits December 16, 2024 19:42

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…dded postAuthRedirect
…igration and building
…cuted when running with docker
oindrila-b and others added 20 commits January 8, 2025 14:07
…orary env values.
@zereraz zereraz merged commit 095af75 into main Jan 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants