Copy values bound to tweak-strings directly into buffers
#2042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brusherru
reviewed
Sep 17, 2020
| @@ -97,6 +97,8 @@ const cppType = def( | |||
| ) | |||
| ); | |||
|
|
|||
| const escapeCppString = str => R.replace(/"/g, '\\"', unquote(str)); | |||
There was a problem hiding this comment.
It's time to make escaping safer.
Here is the case that fails in compile-time, but the same tweak value then works fine in live session: "mwa\\ha"ha\" (first and last quotes is a part of literal)
brusherru
approved these changes
Sep 18, 2020
This was referenced Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes a problem with
tweak-string-*s introduced in v0.35.0 and generally optimises memory usage.