Move contribution steps to its own file #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
requested changes
Nov 14, 2023
| ``` | ||
| 5. Create a new branch from the `main` branch. | ||
| 6. Make your changes. | ||
| 7. Create a pull request. |
There was a problem hiding this comment.
We need to add a note here:
Before creating a pull request, run the Dart format and Flutter analyze for a merge check using Melos, ensuring compatibility with the minimum supported Flutter version, which is 3.7.2.
melos run format
melos run analyzeThere was a problem hiding this comment.
I thought about it. I think, it is better to include it in the pull request template. So that they will need to click check mark to verify that melos analyze doesn't produce any errors, etc.
There was a problem hiding this comment.
So in contributing.md; we introduce how the contribution works, and handle the details in the respective area, in this case in the PR.
I liked how it is handled in flutterfire, for example.
ulusoyca
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the first step of adding guidelines; we are moving contribution steps to its own file.
We will have two more PRs about;