Allow custom top bar widget to be "not always visible" #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
force-pushed
the
use-custom-top-bar-in-scroll-animation
branch
from
aa99c21 to
b7c100c
Compare
TahaTesser
approved these changes
Oct 9, 2023
lib/src/content/components/main_content/wolt_modal_sheet_top_bar.dart
Outdated
Show resolved
Hide resolved
…ar.dart Co-authored-by: Taha Tesser <[email protected]>
…ar.dart Co-authored-by: Taha Tesser <[email protected]>
Co-authored-by: Taha Tesser <[email protected]>
Co-authored-by: Taha Tesser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the custom top bar widget operates exclusively when the
isTopBarLayerAlwaysVisibleis set totrue. Setting this tofalsewhen custom top bar is used triggers an exception. This PR introduces the flexibility to enable the custom top bar to be used even whenisTopBarLayerAlwaysVisibleis set totrue.Changes Introduced:
WoltModalSheetPage.topBarwidget is provided, it will be wrapped with shadow and elevation determined by the theme or default settings. Without aWoltModalSheetPage.topBar,a default top bar will be generated, styled according to the theme settings.WoltModalSheetPage.topBarTitle.isTopBarLayerAlwaysVisiblefalseisTopBarLayerAlwaysVisibletruenot_always_visible.mov
top_bar_always_visible.mov