Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw a helpful error message when returning an empty list in pageListBuilder #68

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Throw a helpful error message when returning an empty list in pageListBuilder #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/src/wolt_modal_sheet.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,7 @@ class _WoltModalSheetState extends State<WoltModalSheet> {
valueListenable: pagesListBuilderNotifier,
builder: (context, pagesBuilder, _) {
final pages = pagesBuilder(context);
assert(pages.isNotEmpty, 'pageListBuilder must return a non-empty list.');
return ValueListenableBuilder<int>(
valueListenable: pageIndexNotifier,
builder: (_, int pageIndex, __) {
Expand Down
4 changes: 3 additions & 1 deletion test/wolt_modal_sheet_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ void main() {
await tester.tap(find.text('Open sheet'));
await tester.pumpAndSettle();

expect(tester.takeException(), isNotNull);
final AssertionError exception = tester.takeException() as AssertionError;
expect(exception, isAssertionError);
expect(exception.message, 'pageListBuilder must return a non-empty list.');
});
});

Expand Down