[Issue-55] Fix barrierDismissible parameter has no effect to prevent modal dismissing
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulusoyca
changed the title
barrierDismissible parameter has no effect to prevent modal dismissing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the bug where even when barrierDismissible was set to false, the modal could still be dismissed when tapping on the barrier.
Changes
Added a condition to check for
barrierDismissible. If it's true, only then it will decide whether to use onModalDismissedWithBarrierTap or fall back to Navigator.of(context).pop.Added Tests
Ensure that when
barrierDismissibleis true, the modal can be dismissed by tapping outside.Ensure that when
barrierDismissibleis false, the modal cannot be dismissed by tapping outside.By making this change, we ensure that the modal dismissal respects the
barrierDismissibleproperty, and it provides a consistent user experience.