Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show page with type and selector #351

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

gazialankus
Copy link
Contributor

Description

Implements the navigation method described in #346. I added example usage but did not check whether test still work.

2024-12-16 17_37_31-playground 2024-12-16 17_37_43-playground 2024-12-16 17_38_00-playground

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

@ulusoyca ulusoyca self-requested a review December 16, 2024 15:10
@ulusoyca ulusoyca self-assigned this Dec 16, 2024
@ulusoyca ulusoyca force-pushed the show_page_with_type_and_selector branch from bd5e28c to aab7869 Compare December 16, 2024 16:29
@gazialankus gazialankus requested a review from ulusoyca December 16, 2024 16:50
@ulusoyca
Copy link
Collaborator

Huge thanks for the contribution 👑

@ulusoyca ulusoyca merged commit 78bf0d3 into woltapp:main Dec 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants