fix gesture detector onDrag callback #324
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukireus
reviewed
Sep 10, 2024
There was a problem hiding this comment.
Hi, thank you for your contribution.
I've reviewed your PR and noticed some formatting issues. Could you please align your changes with the project's guidelines?
If you need assistance, refer to the CONTRIBUTING.md file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the issue with the GestureDetector's onDrag callback in the WoltModalSheetDragToDismissDetector.
Previously, the callbacks were not properly set to null when they needed to be disabled, which caused them to remain active unintentionally.
This is realated to issue #322