Expose page list, current page, and getters for isAtLastPage / isAtFirstPage #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaTesser
reviewed
Aug 11, 2024
TahaTesser
requested changes
Aug 11, 2024
ulusoyca
force-pushed
the
expose-page-list
branch
from
81d6f94 to
81a0ac3
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new getter methods to the
WoltModalSheetto get the current page and current page list.New Getter Methods:
pages: Returns the list of pages currently in the modal sheet.currentPage: Retrieves the current page being displayed in the modal sheet.currentPageIndex: Provides the index of the currently displayed page within the navigation stack.isAtFirstPage: Returns true if the current page is the first in the stack, otherwise false.isAtLastPage: Returns true if the current page is the last in the stack, otherwise false.Related Issues
#297
Testing
New widget tests have been added to verify the correctness of these getter methods. The playground app also now shows the current page index, and total number of pages utilising these methods.
pages_getter.mov