Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional gradient over the sticky action bar #29

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

ulusoyca
Copy link
Collaborator

@ulusoyca ulusoyca commented Jul 29, 2023

Description:

Adds feature from issue: #27

This PR introduces hasSabGradient field in the WoltModalSheetPage. The flag indicates whether a gentle gradient overlay should be rendered above the stickyActionBar within a modal sheet page. This gradient subtly suggests to the user that there may be additional content present below the action bar.

This PR removes the component from the example app and adds to the library.

gradient.mov

@yunusemrebakir yunusemrebakir self-requested a review August 7, 2023 05:34
@yunusemrebakir yunusemrebakir self-assigned this Aug 7, 2023
Copy link
Collaborator

@MuTe33 MuTe33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quite useful PR! 🚢 🚢 🚢 🚢

begin: Alignment.bottomCenter,
end: Alignment.topCenter,
colors: [
backgroundColor,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at some point we could make this even customisable, so that the user can pass in its own gradient. That way the user can use any gradient form and color

@ulusoyca ulusoyca force-pushed the issue-27-add-built-in-sticky-action-bar-gradient branch from 2f8e484 to 0794b09 Compare August 8, 2023 06:19
@ulusoyca ulusoyca merged commit 14c4016 into main Aug 8, 2023
@yunusemrebakir yunusemrebakir deleted the issue-27-add-built-in-sticky-action-bar-gradient branch August 8, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants