Add Coffee Maker Demo App example with navigator 2.0 (Flutter Full Stack Conference) #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Navigator 2 demo app for coffee maker Add demo app for navigator 2 talk
AcarFurkan
reviewed
May 24, 2024
Comment on lines
78
to
84
| const Align( | ||
| alignment: AlignmentDirectional.topStart, | ||
| child: Padding( | ||
| padding: EdgeInsets.all(16.0), | ||
| child: DrawerMenuButton(), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
DrawerMenuButton is not clickable for some devices. We can add SafeAreafor this part and we can rearrange padding.
Comment on lines
51
to
63
| Align( | ||
| alignment: AlignmentDirectional.topStart, | ||
| child: Padding( | ||
| padding: const EdgeInsets.all(16.0), | ||
| child: BackButton( | ||
| style: ButtonStyle( | ||
| backgroundColor: | ||
| MaterialStateProperty.all(Colors.white), | ||
| ), | ||
| onPressed: Navigator.of(context).pop, | ||
| ), | ||
| ), | ||
| ), |
There was a problem hiding this comment.
Also this BackButton need SafeArea
|
Visit the preview URL for this PR (updated for commit 6dcc541):
(expires Tue, 04 Jun 2024 13:07:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 906758393beb0353b979d020649d6a1efc40fb5b |
AcarFurkan
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the demo app for showing how to use Navigator 2.0 with MVVM.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process.
///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?