Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR deployment method #195

Merged
merged 1 commit into from
May 6, 2024

Conversation

AcarFurkan
Copy link
Collaborator

Description

Normally, when you generate PR deployment .yaml file from cli, it comes with on:pull_request. However, if there is a PR coming from the forked repos, github-action does not allow the incoming PR to reach the secrets and cannot receive firebase deployment information. For this reason, I changed pull_request to pull_request_target in the old PR and it could now access the secrets, but the problem this caused was now working in the codes on the deployment main. I missed this while making the last contribution. Currently, I checkout the incoming PR and then deploy. I tested it on my own repos and it works.
sample repository: https://github.com/AcarFurkan/workflow_trial

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

github-actions bot commented May 6, 2024

Visit the preview URL for this PR (updated for commit d6929cd):

(expires Mon, 13 May 2024 19:44:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 906758393beb0353b979d020649d6a1efc40fb5b

@AcarFurkan AcarFurkan requested a review from ulusoyca May 6, 2024 19:49
@AcarFurkan AcarFurkan merged commit 5b85d5e into woltapp:main May 6, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants