Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Normally, when you generate PR deployment .yaml file from cli, it comes with on:pull_request. However, if there is a PR coming from the forked repos, github-action does not allow the incoming PR to reach the secrets and cannot receive firebase deployment information. For this reason, I changed pull_request to pull_request_target in the old PR and it could now access the secrets, but the problem this caused was now working in the codes on the deployment main. I missed this while making the last contribution. Currently, I checkout the incoming PR and then deploy. I tested it on my own repos and it works.
sample repository: https://github.com/AcarFurkan/workflow_trial
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process.
///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?