Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR checks #192

Merged
merged 1 commit into from
May 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
name: Check
flutter_version: &flutter_version "3.10.6" # Uses the minimum supported version.

on:
# Curently, this workflow is triggered by pull request events only.
Expand All @@ -17,15 +16,16 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: subosito/flutter-action@v2
- uses: subosito/flutter-action@v2.16.0
with:
flutter-version: *flutter_version
channel: 'stable'
channel: stable
flutter-version-file: pubspec.yaml # path to pubspec.yaml
# Get Flutter version
- name: Get Flutter version
run: flutter --version
# Get dependencies
- name: Get dependencies
run: flutter pub get
# Setup Melos
- name: Setup Melos
run: dart pub global activate melos
Expand All @@ -48,10 +48,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: subosito/flutter-action@v2
- uses: subosito/flutter-action@v2.16.0
with:
flutter-version: *flutter_version
channel: 'stable'
channel: stable
flutter-version-file: pubspec.yaml # path to pubspec.yaml
# Get Flutter version
- name: Get Flutter version
run: flutter --version
Expand All @@ -68,8 +68,8 @@ jobs:
- name: Run dart format
run: dart format --set-exit-if-changed .
# Run melos format to find format issues in demos
- name: Run melos foramt
run: melos forkat
- name: Run melos format
run: melos format
- name: Check if melos analyze passes
run: echo $?

Expand All @@ -78,10 +78,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: subosito/flutter-action@v2
- uses: subosito/flutter-action@v2.16.0
with:
flutter-version: *flutter_version
channel: 'stable'
channel: stable
flutter-version-file: pubspec.yaml # path to pubspec.yaml
# Get Flutter version
- name: Get Flutter version
run: flutter --version
Expand All @@ -96,6 +96,5 @@ jobs:
run: melos bootstrap
- name: Run tests
run: flutter test
- name: Check if flutter test passes
- name: Check if flutter test passes
run: echo $?

2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ repository: https://github.com/woltapp/wolt_modal_sheet

environment:
sdk: '>=3.0.6 <4.0.0'
flutter: '>=3.10.6'
flutter: 3.10.6

dependencies:
flutter:
Expand Down
Loading