Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hero image in the pub dev example #133

Merged

Conversation

AcarFurkan
Copy link
Collaborator

Description

Issue reported within #91

If we copied the wolt_modal_bottom sheet directly instead of cloning the example from pub.dev, an error would occur because we did not import the assets but only the code. That's why I decided to pull the example from the github repo instead of getting the assets from local. (This bug was solved before, but I solved it again because it did not fit the guidle.)

Error Fixed
Error Fixed

Related Issues

fix #91

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes tests for all changed/updated/fixed behaviors.
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • The package compiles with the minimum Flutter version stated in the pubspec.yaml

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Collaborator

@yunusemrebakir yunusemrebakir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @AcarFurkan!

@yunusemrebakir yunusemrebakir merged commit 3da966e into woltapp:main Feb 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace asset images with network images in the minimal example
2 participants