Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When sheet is scrollable drag to close is not working #282

Closed
dario-digregorio opened this issue Jul 30, 2024 · 4 comments
Closed

When sheet is scrollable drag to close is not working #282

dario-digregorio opened this issue Jul 30, 2024 · 4 comments
Labels
bug Something isn't working in triage

Comments

@dario-digregorio
Copy link

dario-digregorio commented Jul 30, 2024

Bug report

Describe the bug
I noticed when having a scrollable sheet the drag to close gesture is not working properly. Only when grabbing by the handle you can close the modal. If there is no scrollable content the modal can be closed by dragging the content, like expected.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to the wolt modal playground
  2. Select bottom Sheet
  3. See drag behavior when dragging a scrollable content vs a non scrollable content

Expected behavior

Should be able to drag and close no matter if it is a scrollable or not


Additional context

Screen.Recording.2024-07-30.at.10.55.15.mov

@dario-digregorio dario-digregorio added bug Something isn't working in triage labels Jul 30, 2024
@ulusoyca
Copy link
Collaborator

Thanks @dario-digregorio

Closing this since it is duplicate: #262

Ping @AcarFurkan @durannumit

@ulusoyca
Copy link
Collaborator

@dario-digregorio do you think you have time to check this issue as well? If yes, don't hesitate for contribution :)

@dario-digregorio
Copy link
Author

I plan on contributing when I have more time. I will write to you here :)

@ulusoyca
Copy link
Collaborator

ulusoyca commented Aug 5, 2024

@dario-digregorio 0.9.0 added this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working in triage
Projects
None yet
Development

No branches or pull requests

2 participants