-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close bottom sheet on scroll #262
Comments
@MbIXjkee This is a good use case. Do you think that this would work in the new scroll view? |
We are working on this. |
Hey @ulusoyca @josebejao , |
Yes 🤩 if only this is the behaviour when scroll position is 0. What happens in scrolled case? |
This is up to us. If we want, we can use drag properties like the one used by |
The default behavior should be enable drag to dismiss gesture on list view area when main content scroll position is 0. |
On it
|
This is the default behaviour: trim.5AD7E686-B874-4606-85A7-FB7E04D53612.MOV |
That's it, thank you so much. |
@durannumit and @AcarFurkan are working on this feature. I am also looking forward to see how they will address this 👀 |
wolt2.mp4 |
@AcarFurkan amazing work! This is indeed what we are after. When is the PR coming? We can release this before the big day. |
Thank youu :) I wrote some bad code to make a quick demo. If I don't have any extra work today or tomorrow, I want to clean it up and open a PR :) coming soon |
I am gonna be honest. I spent around 30 mins to fix this, and couldn't do it. Really looking forward to it. 🙇 |
@AcarFurkan I improved your solution. It does not have to be a bottom sheet. Our generic solution also does the same for custom modal types and handles all the edge positions considering selected dismiss direction. drag_to_close_bottom_sheet.mov |
@josebejao This is released with 0.9.0 |
Hi,
It's any possibility to close bottom sheet when you are on top of scroll and swipe down ? Like if we touch in title with drag enabled, but on the scroll widget.
Thank you
The text was updated successfully, but these errors were encountered: