Fix some avoid-suspicious-super-overrides issues

woltapp · Nov 18, 2024 · 33396a5 · 33396a5
1 parent cbe0777
commit 33396a5
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/playground_navigator2/lib/router/playground_router_delegate.dart b/playground_navigator2/lib/router/playground_router_delegate.dart
@@ -108,6 +108,8 @@ class PlaygroundRouterDelegate
   @override
   void dispose() {
     _cubitSubscription.cancel();
+    _pageIndexNotifier.dispose();
+    _pageListBuilderNotifier.dispose();
     super.dispose();
   }
 }
diff --git a/playground_navigator2/lib/router/router_pages/home_page.dart b/playground_navigator2/lib/router/router_pages/home_page.dart
@@ -2,7 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:playground_navigator2/home/home_screen.dart';
 
 class HomePage extends Page<void> {
-  const HomePage() : super(key: const ValueKey('HomePage'));
+  const HomePage() : super(key: const ValueKey('HomePage'), name: 'Home Screen');
 
   @override
   Route<void> createRoute(BuildContext context) {
@@ -11,7 +11,4 @@ class HomePage extends Page<void> {
       builder: (context) => const HomeScreen(),
     );
   }
-
-  @override
-  String get name => 'Home Screen';
 }
diff --git a/playground_navigator2/lib/router/router_pages/sheet_page.dart b/playground_navigator2/lib/router/router_pages/sheet_page.dart
@@ -7,7 +7,7 @@ class SheetPage extends Page<void> {
   const SheetPage({
     required this.pageIndexNotifier,
     required this.pageListBuilderNotifier,
-  }) : super(key: const ValueKey('SheetPage'));
+  }) : super(key: const ValueKey('SheetPage'), name: SheetPage.routeName);
 
   final ValueNotifier<int> pageIndexNotifier;
   final ValueNotifier<WoltModalSheetPageListBuilder> pageListBuilderNotifier;
@@ -28,7 +28,4 @@ class SheetPage extends Page<void> {
       settings: this,
     );
   }
-
-  @override
-  String get name => routeName;
 }
diff --git a/playground_navigator2/lib/router/router_pages/unknown_page.dart b/playground_navigator2/lib/router/router_pages/unknown_page.dart
@@ -2,7 +2,7 @@ import 'package:flutter/material.dart';
 import 'package:playground_navigator2/unknown/unknown_screen.dart';
 
 class UnknownPage extends Page<void> {
-  const UnknownPage() : super(key: const ValueKey('UnknownPage'));
+  const UnknownPage() : super(key: const ValueKey('UnknownPage'), name: 'Unknown Screen');
 
   @override
   Route<void> createRoute(BuildContext context) {
@@ -11,7 +11,4 @@ class UnknownPage extends Page<void> {
       builder: (context) => const UnknownScreen(),
     );
   }
-
-  @override
-  String get name => 'Unknown Screen';
 }