Make the ECR version tagging regular expression exactly match the image tag instead of containing #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Currently, the tag of 8 char length short commit SHA on git is expected to be matched as a potential target associated with the deployment environment. However, the current Regex
[0-9a-f]{5,40}
matches any qualified preceding tokens, thus having the logic of "match any". This would cause a problem with unexpected matches, e.g., when a branch name master and timestamp ensemble a tagmaster_1671212099
for example, this will be also matched with the regex, thus violating Wish internal naming convention.So this PR is to make the regex exactly match the tag, instead of "match any".
Testing
Add unit test registry/ecr/provider_test.go
Local Docker build