Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WELD-2810 Add support for sealed classes to the implementation of CDI Lang Model (+ bump to CDI 5.0) #3122

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WELD-2810 Add support for sealed classes to the implementation of CDI Lang Model (+ bump to CDI 5.0) #3122

wants to merge 4 commits into from

Conversation

Ladicek
Copy link
Contributor

@Ladicek Ladicek commented Feb 27, 2025 •
edited by manovotn
Loading

@Ladicek
Copy link
Contributor Author

Ladicek commented Feb 27, 2025 •
edited
Loading

The first commit depends on weld/api#225 and again, doesn't necessarily have to be correct.

The second commit should be good.

@manovotn
Copy link
Contributor

manovotn commented Mar 4, 2025

I've sent #3132 to upgrade project version (and similar for API).
Though we'd still need some Alpha releases to avoid the snapshots :)

@manovotn manovotn changed the title bump to CDI 5.0 + add support for sealed classes to the implementation of CDI Lang Model WELD-2810 Add support for sealed classes to the implementation of CDI Lang Model (+ bump to CDI 5.0) Mar 8, 2025
@manovotn manovotn force-pushed the lang-model-sealed-classes branch from 90095e7 to 7701c21 Compare March 8, 2025 11:44
@manovotn
Copy link
Contributor

manovotn commented Mar 8, 2025

I have updated this branch and rebased it onto master so that it has the fix for lifecycle OM and BeanManager param.
It is still running with SNAPSHOT dependencies, so failures are expected.

Though running it locally, I can now see all the tests passing 👍

@Ladicek
Copy link
Contributor Author

Ladicek commented Mar 10, 2025

You really should feel free to bump to CDI 5.0 API / Weld 7.0 API elsewhere, if that suits you better. The core value of this PR has always been the implementation of the sealed classes support in the lang model.

@manovotn
Update CDI TCK to 5.0.Alpha1.
2ae5805 
Update Weld API to 7.0.Alpha1.
@manovotn manovotn force-pushed the lang-model-sealed-classes branch from 7701c21 to 2ae5805 Compare March 20, 2025 15:16
@manovotn manovotn marked this pull request as ready for review March 20, 2025 15:16
@manovotn
Copy link
Contributor

manovotn commented Mar 20, 2025 •
edited
Loading

Updated Weld API and CDI TCK versions to newly released Alpha1 versions; moved from draft to ready for review.
CI should now run and provide some meaningful results.

@manovotn manovotn force-pushed the lang-model-sealed-classes branch from 1b378a9 to dcc04d0 Compare March 20, 2025 15:40
@manovotn
Copy link
Contributor

Uff, these failures are related but I am not sure how much we can do now.

There are calls to BM#getELResolver() which is removed in CDI 5. Now, these calls can be either from WFLY integration code or faces impl, none of which can be easily modified. Even WFLY doesn't yet have a version for EE 11, so none that would reliably operate on CDI 4.1 to have access to the new EL API 🤔

I'll poke around WFLY internals to at least get clarity on what the problems are and create some tracking issue for them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ladicek @manovotn