Restore playback state when reopening player #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,12 +34,20 @@ module.exports = class PlaybackController { | |||
| else this.play() | |||
| }) | |||
| } else { | |||
| let initialized = false | |||
There was a problem hiding this comment.
I had an idea to set torrentSummary.mostRecentFileIndex instead of using the initialized variable and remove the index param from openPlayer, but I don't think it's the best solution after all.
|
@mathiasvr yeah ill rebase #885 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up for PR #871.
The intended behavior was that when opening player, playing some files and then navigating backward/forward in the app, the playback state is restored. In one particular case, when we open a specific file instead of a torrent and then do the above, the playback starts again at the same file it started at instead.
This PR fixes that.