Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #804

Merged
merged 2 commits into from
Aug 22, 2016
Merged

Bugfixes #804

merged 2 commits into from
Aug 22, 2016

Conversation

dcposch
Copy link
Contributor

@dcposch dcposch commented Aug 22, 2016

Here's our current list of top 10 bugs from https://webtorrent.io/desktop/telemetry/:

Count Example message Status
2104 [object Object] No idea, no stacktrace
632 [object HTMLVideoElement] No idea, no stacktrace
359 Cannot read property 'getHostNode' of null Happens after a React component throws an error in render(). Will go away by itself once we fix those errors, logged separately.
284 Failed to set the 'currentTime' property on 'HTMLMediaElement': The provided double value is non-finite. Fixed in this PR
78 Cannot read property '0' of undefined Fixed in this PR
62 Illegal wire type for field Message.Field... Filed: thibauts/node-castv2#35
59 torrent is destroyed Bug in webtorrent.js, already filed
51 You can't connect to dlna when already connected to another device Np. Comes from our own UI; should just use addError instead of throwing an uncaught exception.
48 val is not defined Filed: thibauts/node-castv2#36
47 Cannot read property 'message' of undefined Bug in older version of WebTorrent, can't happen in the current telemetry.js

Before, if you added a magnet link and then tried to delete the torrent plus data before the file list was loaded, it would fail and throw an uncaught error

Fixes #803
@dcposch
Copy link
Contributor Author

dcposch commented Aug 22, 2016

@feross

@feross
Copy link
Member

feross commented Aug 22, 2016

LGTM!

@feross feross merged commit 6a46609 into master Aug 22, 2016
@feross feross deleted the dc/fixes branch August 22, 2016 23:46
@feross
Copy link
Member

feross commented Aug 22, 2016

This is amazing. Telemetry is extremely usefu! It would have taken forever to fix these issues without this, waiting for issues to get filed.

@dcposch dcposch mentioned this pull request Aug 23, 2016
17 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants