Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen stacking bug #770

Merged
merged 1 commit into from
Aug 12, 2016
Merged

Fix screen stacking bug #770

merged 1 commit into from
Aug 12, 2016

Conversation

dcposch
Copy link
Contributor

@dcposch dcposch commented Aug 10, 2016

You can no longer open a whole stack of Prefs windows, or Create Torrent windows

Simplifies and fixes behavior when dropping files onto the app or the dock icon. Before, you could use drag-drop to create stacks of Create Torrent windows. Now, you can only create torrents from the home screen.

Fixes #665

@dcposch
Copy link
Contributor Author

dcposch commented Aug 10, 2016

@feross

@@ -350,6 +333,17 @@ function getMenuTemplate () {
click: () => dialog.openSeedFile()
})

// Edit -> Preferencs (Windows, Linux)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment should be "Edit menu (Windows, Linux)" to match the style of the others.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@feross
Copy link
Member

feross commented Aug 11, 2016

Nice work! This is a lot more consistent. I like it.

LGTM -- but see inline comments.

You can no longer open a whole stack of Prefs windows, or Create Torrent windows

Simplifies and fixes behavior when dropping files onto the app or the dock icon. Before, you could use drag-drop to create stacks of Create Torrent windows. Now, you can only create torrents from the home screen.

Fixes #665
@dcposch dcposch merged commit 4d48b9e into master Aug 12, 2016
@feross feross deleted the dc/screen branch August 12, 2016 21:51
@feross
Copy link
Member

feross commented Aug 12, 2016

👍

@feross
Copy link
Member

feross commented Aug 20, 2016

Released in WebTorrent Desktop v0.11!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't allow Create Torrent window to open from Prefs window
2 participants