Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application-config@1 #733

Merged
merged 1 commit into from
Jul 23, 2016
Merged

application-config@1 #733

merged 1 commit into from
Jul 23, 2016

Conversation

feross
Copy link
Member

@feross feross commented Jul 23, 2016

This protects against corrupting the configuration file if the
application crashes before the stream finishes writing to the file

Especially important for large configuration files

See LinusU/node-application-config#3

This protects against corrupting the configuration file if the
application crashes before the stream finishes writing to the file

Especially important for large configuration files

See LinusU/node-application-config#3
@bnjmnt4n
Copy link
Member

LGTM

@feross feross merged commit fe4c1b0 into master Jul 23, 2016
@feross feross deleted the f/application-config branch July 23, 2016 09:35
@feross
Copy link
Member Author

feross commented Jul 23, 2016

@demoneaux thanks for the review!

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants