Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup unsupported codec detection #569

Merged
merged 1 commit into from
May 23, 2016
Merged

Cleanup unsupported codec detection #569

merged 1 commit into from
May 23, 2016

Conversation

feross
Copy link
Member

@feross feross commented May 23, 2016

Review: @dcposch

@dcposch
Copy link
Contributor

dcposch commented May 23, 2016

Turns a flat if else into a nested if else, I don't know if that's cleaner but it's fine either way

The variable that used to be called video should def be elem, you're right. LGTM

@dcposch dcposch merged commit 58928b7 into master May 23, 2016
@feross feross deleted the f/codec branch May 23, 2016 06:39
@feross
Copy link
Member Author

feross commented May 23, 2016

Oh, you're right about the nesting. Good call.

mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this pull request May 26, 2016
@feross @dcposch
Cleanup unsupported codec detection (webtorrent#569)
ffce76a 
Review: @dcposch
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@feross @dcposch