Improve subtitle positioning #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we tweaked the subtitle position by modifying the VTT file, line by line with a regex because I did not know it was possible to use CSS for it. But apparently there are Shadow DOM elements that we can use instead. This new approach improves: - Wrapping long lines. Before, the text would go off the edge of the screen. Now it wraps intelligently. - The subtitles move up to get out of the way of the controls when those are visible.
|
Looks reasonable! That regex replace was pretty ugly |
|
Really good change. |
|
Thanks guys! |
mathiasvr
pushed a commit
to mathiasvr/webtorrent-desktop
that referenced
this pull request
May 26, 2016
Before this commit, we tweaked the subtitle position by modifying the VTT file, line by line with a regex because I did not know it was possible to use CSS for it. But apparently there are Shadow DOM elements that we can use instead. This new approach improves: - Wrapping long lines. Before, the text would go off the edge of the screen. Now it wraps intelligently. - The subtitles move up to get out of the way of the controls when those are visible.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, we tweaked the subtitle position by modifying the
VTT file, line by line with a regex because I did not know it was
possible to use CSS for it.
But apparently there are Shadow DOM elements that we can use instead.
This new approach improves:
screen. Now it wraps intelligently.
those are visible.