Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VLC won't minimize and have title #700

Closed
janat08 opened this issue Jul 1, 2016 · 8 comments
Closed

VLC won't minimize and have title #700

janat08 opened this issue Jul 1, 2016 · 8 comments
Labels
Milestone

Comments

@janat08
Copy link

janat08 commented Jul 1, 2016

What version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
Version 0.8.1 (0.95.2)
What operating system and version?
Ubuntu 16.04
What did you do?
Open unsupported format in vlc
What did you expect to happen?
vlc to have title displaying played file in top bar rather than localhost and minimize player
What actually happened?
played file isn't shown, and it won't minimize (vlc).

@janat08
Copy link
Author

janat08 commented Jul 2, 2016

Minimize thing may be ubuntu peculiarity

@Goldob
Copy link
Contributor

Goldob commented Jul 9, 2016

I confirm both issues occuring in Windows 10. Although in my case it's not that the window won't minimize - rather than it is always on top unless minimized.

@mathiasvr
Copy link
Contributor

VLC currently runs with the following arguments:
--play-and-exit, --video-on-top, --no-video-title-show, --quiet
Personally I find always on top annoying, so maybe we should discuss the default options?

@Goldob
Copy link
Contributor

Goldob commented Jul 9, 2016

In other words: it's not a bug, it's a feature.

Anyway, I also think it's irritating and my vote is for getting rid of --video-on-top flag.

The title thing could be more problematic. I thought we could pass --video-title=<string>, but it seems to work only with no video embedded. Need to find a workaround for that. Details here.

@mathiasvr
Copy link
Contributor

mathiasvr commented Jul 9, 2016

I think --video-on-top is there because the vlc window doesn't auto-focus, but this can probably be solved in a different way. The title can be set with --meta-title.

feross added a commit that referenced this issue Jul 27, 2016
Fix #700

The title is set with the `--meta-title` flag to VLC.
@feross feross mentioned this issue Jul 27, 2016
@feross
Copy link
Member

feross commented Jul 27, 2016

@mathiasvr That's right. --video-on-top is a workaround for a VLC issue. As far as I've been able to tell, there's no way to tell VLC to take focus without using --video-on-top. There's a forum thread about it, and I believe there was a bug report as well, but I can't find it now. So, it's expected behavior (at least for now).

@Goldob If someone finds a way to force VLC to come to the front without needing --video-on-top, I'm happy to merge that! I also find floating on top annoying.

As for setting the title in VLC, here's a PR for that: #746

@feross feross added the bug label Jul 27, 2016
feross added a commit that referenced this issue Jul 27, 2016
Fix #700

The title is set with the `--meta-title` flag to VLC.
@feross feross added this to the v0.10 milestone Aug 5, 2016
@ghost
Copy link

ghost commented Nov 16, 2017

This should at the very least be an option in the settings.

@feross I get that it's beneficial that VLC auto-focuses to itself when you play the video, it's after all what you're trying to do. But, the benefit of having VLC auto-focusing and not having to switch windows yourself, is a fraction compared to the annoyance of not being able to minimize / switch windows while the video is running.

It might be a different experience for you as the owner, and I assume it is since you've chosen to see the benefit of auto-focusing as more useful then always-on-top is annoying. But for me personally, this is a reason in itself to not use WebTorrent Desktop. I would rather have to switch to VLC myself, it is after all how VLC works by default, and your software should in no way alter VLC's default behavior. If anything, this is a VLC bug that you should NOT attempt to fix in this library.

@feross
Copy link
Member

feross commented May 4, 2018

@fjeddy We removed the VLC "float on top" behavior in WebTorrent Desktop v0.20.0 released on 2018-04-26.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants