-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard capture of Space and ESC is super aggressive #585
Comments
I assume the fix is to capture those keys only when we're in the player view and it's the active window |
Nah, that's not the solution. The solution is to get make For Play, let's get rid of For |
Sure, but the Play one should still be disabled unless you're in the player. The Go Back will be enabled/disabled the same as the back button |
The Play/Pause menu item that's already there already gets enabled/disabled as the user enters/leaves the player. For the back button, up to you. But I think it's fine to just leave it always enabled and it can just no-op. Otherwise we need to add events to let the main process know about the state of LocationHistory which IMO is more trouble than it's worth. |
While I'm at it, do you want to get rid of this as well?
|
@dcposch Sure. It was a shortcut I was familiar with from Chrome, but I just checked and it does something different now. I say we remove it. The standard OS fullscreen shortcut should be sufficient! Now we can axe that dependency! |
Done |
gWhat version of WebTorrent Desktop? (See the 'About WebTorrent' menu)
0.6.0
What operating system and version?
OS X 10.11.5
What did you do?
Try to use of an OS shortcut with
ESC
orSpace
while WebTorrent Desktop is running.What did you expect to happen?
OS shortcuts should work.
What actually happened?
Any system-wide OS shortcut that makes use of
ESC
orSpace
does not work if WebTorrent Desktop is the active window, because it is captured by the app and theelectron-localshortcut
package.The text was updated successfully, but these errors were encountered: